Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace yarn with npm #906

Closed
wants to merge 1 commit into from
Closed

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented May 12, 2024

No description provided.

@timfish
Copy link
Collaborator Author

timfish commented May 12, 2024

It looks like package-lock.json contains only optional dependencies that were installed on the machine where the lock file was created. This means optional dependencies used like this to install platform specific binaries is currently incompatible with npm!

> rollup --config rollup.config.mjs

/home/runner/work/sentry-electron/sentry-electron/node_modules/rollup/dist/native.js:59
		throw new Error(
		^

Error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.
    at requireWithFriendlyError (/home/runner/work/sentry-electron/sentry-electron/node_modules/rollup/dist/native.js:59:9)
    at Object.<anonymous> (/home/runner/work/sentry-electron/sentry-electron/node_modules/rollup/dist/native.js:68:76)
    ... 3 lines matching cause stack trace ...
    at Module._load (node:internal/modules/cjs/loader:1024:12)
    at Module.require (node:internal/modules/cjs/loader:1233:19)
    at require (node:internal/modules/helpers:179:[18](https://github.com/getsentry/sentry-electron/actions/runs/9050968753/job/24866936833?pr=906#step:5:19))
    at Object.<anonymous> (/home/runner/work/sentry-electron/sentry-electron/node_modules/rollup/dist/shared/parseAst.js:12:[19](https://github.com/getsentry/sentry-electron/actions/runs/9050968753/job/24866936833?pr=906#step:5:20))
    at Module._compile (node:internal/modules/cjs/loader:1358:14) {

@timfish timfish closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant